Add_UI_Test/Cypress/Basic_tests by Lisafiluz · Pull Request #190 · PythonFreeCourse/calendar

Lisafiluz · 2021-02-02T20:18:28Z

No description provided.

…nto add-cypress

…into add-cypress

Develop

Delete user

…into add-cypress

delete-user\add-confirmation

delete-user/fix_comments

Develop

…into add-cypress

…develop

UI-tests/Add_cypress

…into add-cypress

…add-cypress

Add cypress

yammesicka · 2021-02-03T07:02:09Z

Are cypress/support and cypress/plugins necessary?

Lisafiluz · 2021-02-03T07:38:38Z

cypress/support handles all the logic of the commands (functions to doings things in the UI) and services (functions to doings things with requests - directly to the server)

cypress/plugins in not necessary for now, but I'll continue to write tests when the most of the UI functionality will merge to dev so if it never be used I'll delete it.

Gonzom · 2021-02-04T11:13:42Z

tests/tests-ui/cypress/integration/HomePage/cy_HomePage_Resolution.js

+            //cy.url().should('include', '/signIn')
+
+            //cy.get('.signIn_input[name=email]')
+            //.type('fake@email.com')
+            //.should('have.value', 'fake@email.com')


remove commented out code

Gonzom · 2021-02-04T11:14:23Z

tests/tests-ui/cypress/integration/ProfilePage/cy_ProfilePage_Resolutions.js

+    beforeEach(() => {
+        //cy.logIn(true);
+    })
+
+    after(() => {
+        //cy.logOut();
+    })


Is this needed? If not, remove the code

it will be needed, I created the basic template for the tests after the functionality will come its going to be used

Gonzom · 2021-02-04T11:14:46Z

tests/tests-ui/cypress/integration/ProfilePage/cy_User_Card_Actions.js

+    beforeEach(() => {
+        //cy.logIn(true);
+    })
+
+    after(() => {
+        //cy.logOut();
+    })


Is this needed? If not, remove the code

like the comment above

Gonzom · 2021-02-04T11:15:34Z

tests/tests-ui/cypress/plugins/index.js

@@ -0,0 +1,21 @@
+/// <reference types="cypress" />


Is this file needed?

it will, if not ill remove it

Gonzom · 2021-02-04T11:16:22Z

tests/tests-ui/cypress/support/home_page/commands.js

+// ***********************************************
+// This example commands.js shows you how to


Is this file needed?

Gonzom · 2021-02-04T11:24:00Z

Hey, another point which is worth fixing is the file names. The Google JavaScript Style Guide says:

File names must be all lowercase and may include underscores (_) or dashes (-), but no additional punctuation. Follow the convention that your project uses.

So your files such as "ProfilePage/cy_User_Card_Actions.js" should be renamed and I'd say to lowercase, to match our *.py files.

Gonzom · 2021-02-04T11:41:01Z

tests/tests-ui/cypress/support/login/commands_login.js

+Cypress.Commands.add("loginError", (user,password) => {
+	login(user,password);
+	cy.get('.callout').should('contain', 'Incorrect username or password');
+})
+


If I understood this command correctly, it tests if the message contains that specific text. This test will fail if we translate the message (and we are). Can you check for status code instead maybe?

when the login will merge ill check it, for now when we dont yet have login its not called

Gonzom · 2021-02-04T11:48:46Z

tests/tests-ui/cypress/support/login/commands_login.js

+Cypress.Commands.add("logoutUI", () => {
+	cy.get(".icon-account_circle").click();
+	cy.get(".icon-sign-out").click();
+	cy.get('.btn').should('be.visible');
+
+})


I looked at the Cypress documentation for their recommended best practices , and they list from worst to best how to select an element. They discourage selecting by tags, classes or IDs:

Targeting the element above by tag, class or id is very volatile and highly subject to change. You may swap out the element, you may refactor CSS and update ID’s, or you may add or remove classes that affect the style of the element.

Instead, adding the data-cy attribute to the element gives us a targeted selector that’s only used for testing.

The data-cy attribute will not change from CSS style or JS behavioral changes, meaning it’s not coupled to the behavior or styling of an element.

Additionally, it makes it clear to everyone that this element is used directly by test code.

I think we should follow their recommendation here, as I can already see how every small fix in the a css or id name will lead to errors here (I commented on this line, but this is a general comment for how we access selectors in the PR).

we dont have logout yes, Ill add data-cy attribute when we will have logout functionality

Great :) but that was just one example. In tests/tests-ui/cypress/support/enums/enums_profilePage.js you also use this style

yammesicka

Great job! Please resolve the conflicts :)

README.md

…into add-cypress

…into develop

…develop

codecov-io · 2021-02-23T11:06:55Z

Codecov Report

Merging #190 (7dbe7af) into develop (b91708d) will increase coverage by 4.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    95.15%   99.36%   +4.21%     
===========================================
  Files           76       36      -40     
  Lines         3382     1418    -1964     
===========================================
- Hits          3218     1409    -1809     
+ Misses         164        9     -155

Impacted Files	Coverage Δ
app/database/database.py	`100.00% <ø> (ø)`
app/database/models.py	`95.83% <0.00%> (-1.31%)`	⬇️
app/dependencies.py	`100.00% <0.00%> (ø)`
app/telegram/bot.py	`100.00% <0.00%> (ø)`
app/routers/email.py	`100.00% <0.00%> (ø)`
app/internal/email.py	`100.00% <0.00%> (ø)`
app/routers/agenda.py	`100.00% <0.00%> (ø)`
app/routers/export.py	`100.00% <0.00%> (ø)`
app/routers/search.py	`100.00% <0.00%> (ø)`
app/internal/search.py	`100.00% <0.00%> (ø)`
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91708d...b8cd8d3. Read the comment docs.

Add cypress

Lisafiluz · 2021-02-23T11:08:42Z

Conflicts fixed

Gonzom · 2021-02-24T06:24:16Z

app/routers/profile.py

+<<<<<<< HEAD
+        new_user=Depends(get_placeholder_user),
+        new_event=Depends(get_placeholder_event)):
+
+=======
        new_user=Depends(get_placeholder_user)):
+>>>>>>> b91708d299bde83bbd10ff93496b23af9d35dd8f


Lisaf Iluz and others added 30 commits January 16, 2021 11:08

cypress-base

2d1f05d

cypress-build

fd0a9bb

cypress-build

8a14390

cypress-build

8583d31

readme

2f61089

Merge branch 'main' of https://github.com/PythonFreeCourse/calendar i…

219ad38

…nto add-cypress

pull from dev

89aaeec

merge changes

0b9bed3

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

d1e4cfe

…into add-cypress

profile page tests

77d135e

Merge pull request #1 from PythonFreeCourse/develop

25aa774

Develop

delete-user

b9a5bfb

delete_all_events_of_the_user

30b8975

Merge pull request #2 from Lisafiluz/delete-user

7f9e405

Delete user

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

d1217d6

…into add-cypress

delete-user\add-confirmation

34b2bf4

Merge pull request #3 from Lisafiluz/delete-user

fb5aa93

delete-user\add-confirmation

delete-user/fix_comments

ba9838d

Merge pull request #4 from Lisafiluz/delete-user

cdeddaf

delete-user/fix_comments

Merge pull request #5 from PythonFreeCourse/develop

695f0d6

Develop

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

8b8a5ac

…into add-cypress

update readme

9d5c5c8

Merge branch 'develop' of https://github.com/Lisafiluz/calendar into …

bdac43f

…develop

Merge pull request #8 from Lisafiluz/add-cypress

fd405a0

UI-tests/Add_cypress

add git idnore

281ab2c

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

1e833d7

…into add-cypress

Delete tests/tests-ui/node_modules directory

bb2e36e

Merge branch 'develop' of https://github.com/Lisafiluz/calendar into …

ae1486d

…add-cypress

add_cypress_basic_templates

8fc8c42

Merge pull request #10 from Lisafiluz/add-cypress

fdfd5bc

Add cypress

Lisafiluz added 3 commits February 2, 2021 22:12

Update database.py

4c0d3b8

Update profile.py

41c62a7

Update test_profile.py

e07816c

Merge branch 'develop' into develop

602a5f3

Merge branch 'develop' into develop

4d751bc

Gonzom reviewed Feb 4, 2021

View reviewed changes

Update cy_HomePage_Resolution.js

f3aeb5d

yammesicka reviewed Feb 10, 2021

View reviewed changes

README.md Show resolved Hide resolved

Lisaf Iluz added 4 commits February 23, 2021 12:55

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

1b5b1fe

…into add-cypress

Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …

c7568d6

…into develop

conflicts_fix

fb10553

Merge branch 'develop' of https://github.com/Lisafiluz/calendar into …

cc9b06e

…develop

Lisafiluz added 2 commits February 23, 2021 13:07

Merge branch 'develop' into add-cypress

e3a9bc4

Merge pull request #12 from Lisafiluz/add-cypress

b8cd8d3

Add cypress

Gonzom reviewed Feb 24, 2021

View reviewed changes

		// ***********************************************
		// This example commands.js shows you how to

Conversation

Lisafiluz commented Feb 2, 2021

Uh oh!

yammesicka commented Feb 3, 2021

Uh oh!

Lisafiluz commented Feb 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gonzom commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gonzom Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gonzom Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yammesicka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-io commented Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Lisafiluz commented Feb 23, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gonzom commented Feb 4, 2021 •

edited

Loading

Gonzom Feb 4, 2021 •

edited

Loading

Gonzom Feb 4, 2021 •

edited

Loading

yammesicka left a comment •

edited

Loading

codecov-io commented Feb 23, 2021 •

edited

Loading